Skip to content

Conversation

@imreallybadatnames
Copy link
Contributor

Revert non-functional post-test draft changes done to fix a secondary problem [namely passengers being hurt even if the vehicle entity is protected], that, ironically, reverted the actual primary solution [see prev. PR].
Gigantic brain fart on my part; didn't process the mistake until now.

@DaFuqs
Copy link
Owner

DaFuqs commented Nov 24, 2024

Looks good so far.
One thing that comes to mind is that the change does make the Puff Circlet not trigger if the actual damage is smaller than the one the Trinket would use up on dike. Since the Circlet does not proc its effect it may make the players think is is broken / does not trigger in all cases. How should we handle that?

@imreallybadatnames
Copy link
Contributor Author

imreallybadatnames commented Nov 24, 2024

One thing that comes to mind is that the change does make the Puff Circlet not trigger if the actual damage is smaller than the one the Trinket would use up on dike.

uhh that was the initial plan We could just clamp the absorbed dike value between 0 [not including] and the dike cost [including], unless that's a no-go.

@DaFuqs
Copy link
Owner

DaFuqs commented Nov 24, 2024

Sounds perfectly reasonable. Also updating the guidebook lang to mention it uses max of x dike to absorb a fall.

@imreallybadatnames
Copy link
Contributor Author

imreallybadatnames commented Nov 24, 2024

Also, there's a [rather minor] nuance that the full damage is still absorbed even if the dike didn't absorb the cost. How should that be accounted for?

@DaFuqs
Copy link
Owner

DaFuqs commented Nov 24, 2024

Good point.
Only being able to trigger the effect is there is enough dike for the fall (either enough to negate damage, or the max cost) feels like the way to go

@imreallybadatnames
Copy link
Contributor Author

Done. Anyways, should I do the guidebook changes, or...? Seems rather cumbersome, especially considering I don't know most of the supported languages.

@DaFuqs
Copy link
Owner

DaFuqs commented Nov 24, 2024

No prob. I will take a look at the guidebook and see what I can do

@DaFuqs DaFuqs merged commit 1645abb into DaFuqs:1.20.1-aria-for-painters Nov 24, 2024
2 checks passed
@DaFuqs
Copy link
Owner

DaFuqs commented Nov 24, 2024

Guidebook entries & tooltip are worded in a way we do not need to change anything in the first place ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants